Skip to content

test(pkg): don't use (pkg enabled) by default #12652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

test(pkg): don't use (pkg enabled) by default #12652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/blackbox-tests/test-cases/pkg/helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ add_mock_repo_if_needed() {
then
cat >dune-workspace <<EOF
(lang dune 3.20)
(pkg enabled)
(lock_dir
(repositories mock))
(repository
Expand Down Expand Up @@ -140,7 +139,6 @@ create_mock_repo() {
repo="${1:-file://$(pwd)/mock-opam-repository}"
cat >dune-workspace <<EOF
(lang dune 3.20)
(pkg enabled)
(lock_dir
(repositories mock))
(repository
Expand Down
12 changes: 6 additions & 6 deletions test/blackbox-tests/test-cases/pkg/invalid-opam-repo-errors.t/run.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ Test the error cases for invalid opam repositories
> }

$ lock
File "dune-workspace", line 7, characters X-X:
7 | (url ..))
File "dune-workspace", line 6, characters X-X:
6 | (url ..))
Error:
$TESTCASE_ROOT/directory-that-does-not-exist
does not exist
Expand All @@ -30,8 +30,8 @@ Test the error cases for invalid opam repositories
$ rm dune-workspace
$ add_mock_repo_if_needed "file://$(pwd)/empty"
$ lock
File "dune-workspace", line 7, characters X-X:
7 | (url ..))
File "dune-workspace", line 6, characters X-X:
6 | (url ..))
Error:
$TESTCASE_ROOT/empty
is not a directory
Expand All @@ -40,8 +40,8 @@ Test the error cases for invalid opam repositories
$ rm dune-workspace
$ add_mock_repo_if_needed "file://$(pwd)/no-packages-dir"
$ lock
File "dune-workspace", line 7, characters X-X:
7 | (url ..))
File "dune-workspace", line 6, characters X-X:
6 | (url ..))
Error:
$TESTCASE_ROOT/no-packages-dir
doesn't look like a path to an opam repository as it lacks a subdirectory
Expand Down
2 changes: 0 additions & 2 deletions test/blackbox-tests/test-cases/pkg/ocamlformat/helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ EOF
(repository
(name mock)
(url "file://$(pwd)/mock-opam-repository"))

(pkg enabled)
EOF
}

Expand Down
4 changes: 2 additions & 2 deletions test/blackbox-tests/test-cases/pkg/pkg-disabled-workflow.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ Test that dune pkg enabled reports disabled:
Test that pkg commands fail when disabled:

$ dune pkg lock
File "dune-workspace", line 2, characters 5-13:
2 | (pkg disabled)
File "dune-workspace", line 7, characters 5-13:
7 | (pkg disabled)
^^^^^^^^
Error: Package management is disabled in workspace configuration.
Hint: To enable package management, remove the explicit (pkg disabled)
Expand Down
Loading