[RPC] Allow promotion while watch server is running #12010

ElectreAAS · 2025-07-11T11:58:49Z

This PR is a first step towards implementing #11958.
The rpc system was already prepared for this kind of request, but there was no client firing up said request, so I added it.

This PR contains stolen code from Steve's PR #11900 because he added utility functions, but is now rebased on main.

bin/promotion.ml

otherlibs/dune-rpc/private/procedures.ml

shonfeder

Looking good and useful :D I learned a lot during review.

As I am learning, please be sure to LMK if any of my suggestions seem to be based on a misunderstanding.

otherlibs/dune-rpc/v1.mli

otherlibs/dune-rpc/private/procedures.ml

bin/rpc/rpc_common.ml

src/dune_rpc_impl/server.ml

test/expect-tests/dune_rpc_e2e/dune_rpc_diagnostics.ml

shonfeder · 2025-07-12T03:42:16Z

bin/promotion.ml

+    | Error (error : Dune_rpc_private.Response.Error.t) ->
+      Printf.eprintf
+        "Error: %s\n%!"
+        (Dyn.to_string (Dune_rpc_private.Response.Error.to_dyn error))


Do we need to ensure this error is forwarded somehow beyond just an error message? E.v., via an exception or error to get an error exit code?

bin/promotion.ml

src/dune_rpc_impl/server.ml

ElectreAAS · 2025-07-16T09:51:58Z

I tried to address most comments with my latest changes.
~~One thing that is missing however, is a test showcasing the new behaviour and guarding against regressions. I tried making one but failed so far :(~~

There is now a test! The change is subtle but visible

Should there be a changes.md entry? The user-facing behaviour changes ever so slightly

gridbugs · 2025-07-18T06:06:45Z

Should there be a changes.md entry? The user-facing behaviour changes ever so slightly

Yep there should be a changelog entry. Rather than updating changes.md, add a file in doc/changes (see the existing files there to learn the expected format).

src/dune_rpc_impl/server.ml

ElectreAAS · 2025-07-23T16:03:48Z

There is now a changelog entry, and I think I addressed all comments
I'll merge once the CI is green, unless someone stops me ;)

src/dune_rpc_impl/client.ml

bin/rpc/rpc_common.mli

src/dune_engine/build_system_error.mli

src/dune_engine/process.ml

src/dune_engine/build_system_error.ml

Signed-off-by: Ambre Austen Suhamy <[email protected]>

…mote Signed-off-by: Ambre Austen Suhamy <[email protected]>

Signed-off-by: Ambre Austen Suhamy <[email protected]>

…dn't have been deleted Signed-off-by: Ambre Austen Suhamy <[email protected]>

Signed-off-by: Ambre Austen Suhamy <[email protected]>

* Demonstrate what moving everything into dune_rpc_private means * Previous commit was just copying, this is really moving things Signed-off-by: Ambre Austen Suhamy <[email protected]>

Signed-off-by: Ambre Austen Suhamy <[email protected]>

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@` and `@@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11836, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

ElectreAAS added rpc watch mode labels Jul 11, 2025

ElectreAAS commented Jul 11, 2025

View reviewed changes

bin/promotion.ml Show resolved Hide resolved

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch from 7e594bf to 8bda612 Compare July 11, 2025 12:21

ElectreAAS requested review from gridbugs, rgrinberg and shonfeder July 11, 2025 12:22

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch from 8bda612 to c2518a6 Compare July 11, 2025 12:42

rgrinberg reviewed Jul 11, 2025

View reviewed changes

otherlibs/dune-rpc/private/procedures.ml Outdated Show resolved Hide resolved

shonfeder reviewed Jul 12, 2025

View reviewed changes

gridbugs reviewed Jul 15, 2025

View reviewed changes

src/dune_rpc_impl/server.ml Outdated Show resolved Hide resolved

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch 2 times, most recently from c48a129 to 7b4b724 Compare July 16, 2025 09:25

ElectreAAS mentioned this pull request Jul 16, 2025

[RPC] Added a test showing the current promotion capabilities #12029

Merged

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch from 2997c50 to a1eae32 Compare July 17, 2025 14:18

ElectreAAS mentioned this pull request Jul 22, 2025

[RPC] Allow formatting while watch server is running #12064

Merged

ElectreAAS commented Jul 23, 2025

View reviewed changes

src/dune_rpc_impl/server.ml Outdated Show resolved Hide resolved

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch from a1eae32 to dc319bf Compare July 23, 2025 16:02

rgrinberg requested changes Jul 24, 2025

View reviewed changes

src/dune_rpc_impl/client.ml Outdated Show resolved Hide resolved

rgrinberg reviewed Jul 24, 2025

View reviewed changes

bin/rpc/rpc_common.mli Outdated Show resolved Hide resolved

ElectreAAS mentioned this pull request Jul 25, 2025

Demonstrate what moving everything into dune_rpc_private means ElectreAAS/dune#1

Merged

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch from a318d7a to d294d3d Compare July 25, 2025 16:33

rgrinberg reviewed Jul 25, 2025

View reviewed changes

src/dune_engine/build_system_error.mli Outdated Show resolved Hide resolved

rgrinberg reviewed Jul 25, 2025

View reviewed changes

src/dune_engine/process.ml Outdated Show resolved Hide resolved

rgrinberg reviewed Jul 25, 2025

View reviewed changes

src/dune_engine/build_system_error.ml Outdated Show resolved Hide resolved

rgrinberg approved these changes Jul 25, 2025

View reviewed changes

Allow promotion while watch server is running

12d3bb8

Signed-off-by: Ambre Austen Suhamy <[email protected]>

ElectreAAS added 9 commits July 28, 2025 11:59

refactor: move as much as possible into rpc_common

6234766

Signed-off-by: Ambre Austen Suhamy <[email protected]>

Added clarifying comments

c794c1a

Signed-off-by: Ambre Austen Suhamy <[email protected]>

[RPC] Added a test showing the current promotion capabilities

50bcf9c

Signed-off-by: Ambre Austen Suhamy <[email protected]>

Explain the difference between decl.promote and procedures.public.pro…

f27e386

…mote Signed-off-by: Ambre Austen Suhamy <[email protected]>

Added changelog entry

dbb0fe2

Signed-off-by: Ambre Austen Suhamy <[email protected]>

Reintroduce the RPC server's implementation of the old promote, shoul…

6b4857d

…dn't have been deleted Signed-off-by: Ambre Austen Suhamy <[email protected]>

Nit: simpler function name

78b83c8

Signed-off-by: Ambre Austen Suhamy <[email protected]>

Actually move everything needed for promote_many into dune_rpc_private

d3a4ed0

* Demonstrate what moving everything into dune_rpc_private means * Previous commit was just copying, this is really moving things Signed-off-by: Ambre Austen Suhamy <[email protected]>

Add alias for compound_user_error in the engine

655b2ed

Signed-off-by: Ambre Austen Suhamy <[email protected]>

ElectreAAS force-pushed the fmt-concurrent-with-watch-mode branch from 2fa5a19 to 655b2ed Compare July 28, 2025 09:59

Merge branch 'main' into fmt-concurrent-with-watch-mode

7671d99

ElectreAAS merged commit b60beb9 into ocaml:main Jul 28, 2025
22 of 25 checks passed

ElectreAAS deleted the fmt-concurrent-with-watch-mode branch July 28, 2025 12:12

maiste mentioned this pull request Jul 28, 2025

[new release] dune (15 packages) (3.20.0~alpha0) ocaml/opam-repository#28267

Closed

maiste mentioned this pull request Jul 30, 2025

[new release] dune (15 packages) (3.20.0~alpha1) ocaml/opam-repository#28276

Closed

maiste mentioned this pull request Aug 5, 2025

[new release] dune (15 packages) (3.20.0~alpha2) ocaml/opam-repository#28298

Closed

maiste mentioned this pull request Aug 6, 2025

[new release] dune (15 packages) (3.20.0~alpha3) ocaml/opam-repository#28302

Closed

maiste mentioned this pull request Aug 12, 2025

[new release] dune (15 packages) (3.20.0~alpha4) ocaml/opam-repository#28333

Closed

maiste mentioned this pull request Aug 19, 2025

[new release] dune (15 packages) (3.20.0) ocaml/opam-repository#28357

Merged

ElectreAAS mentioned this pull request Sep 8, 2025

[RPC] Allow formatting while watch server is running #11958

Closed

ElectreAAS mentioned this pull request Sep 17, 2025

Allow running tests concurrently with watch server, again! #12473

Merged

[RPC] Allow promotion while watch server is running #12010

[RPC] Allow promotion while watch server is running #12010

Uh oh!

Conversation

ElectreAAS commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shonfeder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shonfeder Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ElectreAAS commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gridbugs commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ElectreAAS commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ElectreAAS commented Jul 11, 2025 •

edited

Loading

ElectreAAS commented Jul 16, 2025 •

edited

Loading

gridbugs commented Jul 18, 2025 •

edited

Loading