Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dune doesn't kill process group when cleaning up #4773

Closed
rgrinberg opened this issue Jun 24, 2021 · 2 comments · Fixed by #4998
Closed

Dune doesn't kill process group when cleaning up #4773

rgrinberg opened this issue Jun 24, 2021 · 2 comments · Fixed by #4998
Labels
Milestone

Comments

@rgrinberg
Copy link
Member

Extracted from here. Dune should kill the entire process group. This requires killpg bindings.

@aalekseyev
Copy link
Collaborator

Copying my comment from there:

It's not simply a matter of writing bindings, it also means that we'd have to spawn every process in its own process group, which means that we need a patch for spawn and that Ctrl+C will no longer be sent to them etc. All of that is probably fine, just not such a self-contained change as one might expect.

@aalekseyev
Copy link
Collaborator

This is related to #3941

@rgrinberg rgrinberg linked a pull request Oct 13, 2021 that will close this issue
@rgrinberg rgrinberg added this to the 3.0 milestone Oct 13, 2021
@ghost ghost closed this as completed in #4998 Oct 14, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants