Skip to content

Commit 20e1a09

Browse files
punchaganLeonidas-from-XIV
authored andcommitted
Subtle hint that topics is not a keyword
Number of projects in the opam-repository have the word topics as one of the tags, presumably because of the structure of the `tags` sexp in the dune-project file generated on `dune init`. See ocurrent/opam-ci-check#26 Signed-off-by: Puneeth Chaganti <[email protected]>
1 parent beea68f commit 20e1a09

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

bin/dune_init.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ module Component = struct
391391
~dir
392392
~synopsis:(Some "A short synopsis")
393393
~description:(Some "A longer description")
394-
~tags:[ "topics"; "to describe"; "your"; "project" ]
394+
~tags:[ "add topics"; "to describe"; "your"; "project" ]
395395
~depends:
396396
[ { Package_dependency.name = Package.Name.of_string "ocaml"
397397
; constraint_ = None

test/blackbox-tests/test-cases/dune-init.t/run.t

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ In particular, the `dune-project` file has the expected content:
359359
(description "A longer description")
360360
(depends ocaml dune)
361361
(tags
362-
(topics "to describe" your project)))
362+
("add topics" "to describe" your project)))
363363

364364
; See the complete stanza docs at https://dune.readthedocs.io/en/stable/reference/dune-project/index.html
365365

@@ -379,7 +379,7 @@ And the opam file will be generated as expected
379379
maintainer: ["Maintainer Name <maintainer@example.com>"]
380380
authors: ["Author Name <author@example.com>"]
381381
license: "LICENSE"
382-
tags: ["topics" "to describe" "your" "project"]
382+
tags: ["add topics" "to describe" "your" "project"]
383383
homepage: "https://github.com/username/reponame"
384384
doc: "https://url/to/documentation"
385385
bug-reports: "https://github.com/username/reponame/issues"
@@ -469,7 +469,7 @@ In particular, the `dune-project` file has the expected content:
469469
(description "A longer description")
470470
(depends ocaml dune)
471471
(tags
472-
(topics "to describe" your project)))
472+
("add topics" "to describe" your project)))
473473

474474
; See the complete stanza docs at https://dune.readthedocs.io/en/stable/reference/dune-project/index.html
475475

@@ -489,7 +489,7 @@ And the opam file will be generated as expected
489489
maintainer: ["Maintainer Name <maintainer@example.com>"]
490490
authors: ["Author Name <author@example.com>"]
491491
license: "LICENSE"
492-
tags: ["topics" "to describe" "your" "project"]
492+
tags: ["add topics" "to describe" "your" "project"]
493493
homepage: "https://github.com/username/reponame"
494494
doc: "https://url/to/documentation"
495495
bug-reports: "https://github.com/username/reponame/issues"

0 commit comments

Comments
 (0)