This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Use deployments for workers. #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure quite how to resolve the merge conflicts, as master now does some extra bits. @mikebryant might be able to figure it out? There are only three conflicts in one file. |
Closing this pull request to stale it. We will review this at a later stage and perhaps re-open it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olaf: Closing this pull request to stale it. We will review this at a later stage and perhaps re-open it.
Should probably change so that rather than deleting/recreating a worker on code change instead just kill the pod (the remade pod will then pull the changed code).