Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in AEP, use active_test=False #107

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 8, 2018

This is important to consider all move lines in computations.
Without this, a formula based on deactivated taxes would
return no result, which is wrong since the corresponding
move lines do exist.

@sbidoul sbidoul force-pushed the 10.0-active_test-false-sbi branch from 288287d to 52732c1 Compare July 8, 2018 15:10
This is important to consider all move lines in computations.
Without this, a formula based on deactivated taxes would
return no result, which is wrong since the corresponding
move lines do exist.
@sbidoul sbidoul force-pushed the 10.0-active_test-false-sbi branch from 52732c1 to 70855cb Compare July 8, 2018 15:22
@sbidoul
Copy link
Member Author

sbidoul commented Jul 31, 2018

@jbeficent @benwillig do you have an opinion on this one?

@benwillig
Copy link
Contributor

In my opinion, it's logic to disable the active test. But maybe it should be an option in the MIS report instance (or maybe a checkbox in the instance view). If not the user should be informed that we also get data linked to inactive objects, because if the user check the journal items, he might be confused about the differences between the report and the data shown in the list view.

@sbidoul
Copy link
Member Author

sbidoul commented Aug 1, 2018

@benwillig I thought about that too, but I could not imagine a realistic situation where this could cause in issue in practice. Do you have one in mind?

@benwillig
Copy link
Contributor

No I have no real use case.

@sbidoul sbidoul merged commit 6868ba5 into OCA:10.0 Oct 1, 2018
@sbidoul sbidoul deleted the 10.0-active_test-false-sbi branch October 1, 2018 16:29
@sbidoul
Copy link
Member Author

sbidoul commented Oct 1, 2018

Tested in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants