Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete menu translation for macOS #808

Open
destroy314 opened this issue Jun 3, 2023 · 5 comments
Open

Incomplete menu translation for macOS #808

destroy314 opened this issue Jun 3, 2023 · 5 comments

Comments

@destroy314
Copy link

Some of the buttons are shown in English.

The texts are translated, they just don’t show:

SYSTEM INFO:
	Obsidian version: v1.3.4
	Installer version: v1.1.16
	Operating system: Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 22.4.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Legacy editor: off
	Base theme: adapt to system
	Community theme: none
	Snippets enabled: 0
	Restricted mode: on

RECOMMENDATIONS:
	none
@ericaxu
Copy link
Contributor

ericaxu commented Jun 6, 2023

Thank you for letting us know!

@liamcain : when you have time, could you please check if it's possible to translate these?

@x-Ai
Copy link
Contributor

x-Ai commented Aug 3, 2023

Thank you for letting us know!

@liamcain : when you have time, could you please check if it's possible to translate these?

The multiple texts in the menu are not derived from the array menuItems, but use the default text of electron, and there is also default menu text in the main thread, so we cannot perform localization translation, please modify the code.

@ericaxu ericaxu changed the title Incomplete menu translation for mac Incomplete menu translation for macOS Aug 3, 2023
@ericaxu
Copy link
Contributor

ericaxu commented Aug 3, 2023

Thank you for letting us know!
@liamcain : when you have time, could you please check if it's possible to translate these?

The multiple texts in the menu are not derived from the array menuItems, but use the default text of electron, and there is also default menu text in the main thread, so we cannot perform localization translation, please modify the code.

I understand the issue. However, due to the interaction between translation module and electron, it's doable but not an easy thing to do. Some engineering changes are required. I'll update this issue when those texts are ready to be translated, thanks for raising this issue!

@x-Ai
Copy link
Contributor

x-Ai commented Aug 17, 2023

okay, I'm really looking forward to a fully localized language interface, it would make people love this software even more.

@kjyv
Copy link

kjyv commented May 13, 2024

Any progress here? I'm not using the translated interface as a lot of strings are not translated, in the menu and also context menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants