From 689cb59923c8cf186e745fdd2d74b7cacbb1176f Mon Sep 17 00:00:00 2001
From: Tom Batchelor <tom.batchelor@me.com>
Date: Wed, 9 Oct 2024 15:39:58 -0700
Subject: [PATCH] feat: add  http_endpoint_s3_backup_mode var to cross-account
 (#58)

Co-authored-by: Tom Batchelor <tom@observeinc.com>
---
 examples/cross-account/README.md    | 1 +
 examples/cross-account/main.tf      | 2 ++
 examples/cross-account/variables.tf | 7 +++++++
 3 files changed, 10 insertions(+)

diff --git a/examples/cross-account/README.md b/examples/cross-account/README.md
index 1c54474..8cd8535 100644
--- a/examples/cross-account/README.md
+++ b/examples/cross-account/README.md
@@ -89,6 +89,7 @@ Note that this will create AWS resources - once you are done, run `terraform des
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_external_ids"></a> [external\_ids](#input\_external\_ids) | External ID array | `list(string)` | `null` | no |
+| <a name="input_http_endpoint_s3_backup_mode"></a> [http\_endpoint\_s3\_backup\_mode](#input\_http\_endpoint\_s3\_backup\_mode) | S3 backup mode for Kinesis Firehose HTTP endpoint. By default, only data that cannot be delivered to Observe via HTTP is written to S3. To backup all data to S3, set this to `AllData`. | `string` | `"FailedDataOnly"` | no |
 | <a name="input_name"></a> [name](#input\_name) | Name for firehose and matching IAM role | `string` | n/a | yes |
 | <a name="input_observe_collection_endpoint"></a> [observe\_collection\_endpoint](#input\_observe\_collection\_endpoint) | Observe Collection Endpoint, e.g https://123456789012.collect.observeinc.com | `string` | n/a | yes |
 | <a name="input_observe_token"></a> [observe\_token](#input\_observe\_token) | Observe token | `string` | n/a | yes |
diff --git a/examples/cross-account/main.tf b/examples/cross-account/main.tf
index 47ed317..512def8 100644
--- a/examples/cross-account/main.tf
+++ b/examples/cross-account/main.tf
@@ -15,6 +15,8 @@ module "observe_kinesis_firehose" {
 
   name                 = var.name
   cloudwatch_log_group = aws_cloudwatch_log_group.group
+
+  http_endpoint_s3_backup_mode = var.http_endpoint_s3_backup_mode
 }
 
 resource "aws_iam_role" "this" {
diff --git a/examples/cross-account/variables.tf b/examples/cross-account/variables.tf
index a68a4e7..cb9eed1 100644
--- a/examples/cross-account/variables.tf
+++ b/examples/cross-account/variables.tf
@@ -13,6 +13,13 @@ variable "name" {
   description = "Name for firehose and matching IAM role"
 }
 
+variable "http_endpoint_s3_backup_mode" {
+  type        = string
+  description = "S3 backup mode for Kinesis Firehose HTTP endpoint. By default, only data that cannot be delivered to Observe via HTTP is written to S3. To backup all data to S3, set this to `AllData`."
+  nullable    = false
+  default     = "FailedDataOnly"
+}
+
 variable "user_arn" {
   type        = string
   description = "ARN for external user granted access to assume role"