Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the voronoi mark should consider the pointer as indicating which cell to show #1622

Closed
Fil opened this issue May 23, 2023 · 1 comment · Fixed by #1623
Closed

the voronoi mark should consider the pointer as indicating which cell to show #1622

Fil opened this issue May 23, 2023 · 1 comment · Fixed by #1623
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented May 23, 2023

The voronoi diagram is computed at render for the subset (grouped by Z) of the index, but with Plot.pointer what we mean is "show this cell from the (unpointed) voronoi", not "create a voronoi from this one point".

@Fil Fil added the enhancement New feature or request label May 23, 2023
@mbostock
Copy link
Member

I prefer to frame this more generally as: the Voronoi mark should compute the Voronoi diagram during initialization, and then render a subset of cells using the passed index at runtime. In other words, the Voronoi mark shouldn’t know about the pointer transform, but it should respect the index that is passed to the render function, which may be a subset of the index during initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants