From 6c7f17c1aff810fe04eb32ba9c0a09aec181ce43 Mon Sep 17 00:00:00 2001 From: Mike Bostock Date: Tue, 3 Sep 2024 07:26:28 -0700 Subject: [PATCH 1/2] detect non-local sql tables --- src/resolvers.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/resolvers.ts b/src/resolvers.ts index 7f473607b..7b1a857f0 100644 --- a/src/resolvers.ts +++ b/src/resolvers.ts @@ -123,8 +123,11 @@ export async function getResolvers( // Add SQL sources. if (page.data.sql) { - for (const source of Object.values(page.data.sql)) { - files.add(String(source)); + for (const value of Object.values(page.data.sql)) { + const source = String(value); + if (isAssetPath(source)) { + files.add(source); + } } } From 00078d9199284c6844ecdb9caa6a23e383c43128 Mon Sep 17 00:00:00 2001 From: Mike Bostock Date: Tue, 3 Sep 2024 07:58:32 -0700 Subject: [PATCH 2/2] avoid import for remote-only sql --- src/render.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/render.ts b/src/render.ts index 926f24e19..4b2f2efe3 100644 --- a/src/render.ts +++ b/src/render.ts @@ -59,7 +59,7 @@ if (location.pathname.endsWith("/")) { import ${preview || page.code.length ? `{${preview ? "open, " : ""}define} from ` : ""}${JSON.stringify( resolveImport("observablehq:client") )};${ - files.size || data?.sql + files.size ? `\nimport {registerFile${data?.sql ? ", FileAttachment" : ""}} from ${JSON.stringify( resolveImport("observablehq:stdlib") )};`