-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose changing the label on the NCBI top level term to 'NCBI root' #10
Comments
Or even spell it out to "NCBI organism taxonomy root" ? |
if we change it, it should be to "organism" (although some subclasses are not organisms) |
Bringing this up again. Very in favour of that! |
…lasses **please read closely and read the related issue before commenting** This PR removed the statement that COB:organism = NCBITaxon:root Rationale: root includes non-organisms such as samples See obophenotype/ncbitaxon#10 This PR replaces that link with two subClassOf axioms * COB:organism * NCBITaxon:Viruses * NCBITaxon:cellular organisms Note that if this were merged, then the union of NCBITaxon and COB would have a lattice at the top. However, it would be trivial to add NCBITaxon:1 to an anti-slim and filter it out, resulting in a tree with COB:organism as the single MRCA of all organism classes Merging this PR has some advantages such as obviating the need to rename NCBITaxon:1, since we instead simply inject our own true parent. It leaves the structure of labeling of NCBITaxon intact **Important** please refrain from discussing the definition of organism here, specifically whether it includes viruses. For COB purposes, this is a closed issue. See: #6
@ehartley, exactly, many subclasses are not organism! I think there is one coherent path forward, which is to inject COB organism as a superclass of cellular organisms and virus
After this we can simply ignore NCBITaxon:1 and its awkward confusing name. We would simply have all imports start from subclasses of COB:organism. We could also have a separate subset release of NCBITaxon with only these classes |
We had created the union class in CARO to address this issue: http://purl.obolibrary.org/obo/CARO_0001010 |
There are two issues mixed up here:
|
In the Planteome project, we have found an issue since the NCBI top level term is called "root" and it conflicts with our PO term root (PO:0009005) in Protege, and looks weird on the AmiGO browser, .
Suggest that we need to add a modification of the NCBI top level term, which in NCBI is called "root" to be 'NCBI root'.
I have contacted them and asked them to change it at their end, but they won't as we are the only ones who it is an issue for, apparently.
See original post here: Planteome/planteome-ncbi-taxonomy#1
The text was updated successfully, but these errors were encountered: