-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts not copied correctly with Android Gradle Plugin 4.1.0 #1265
Comments
The problem is going to be somewhere in here but my gradle-fu is not quite strong enough to fix it: react-native-vector-icons/fonts.gradle Lines 42 to 56 in 3458ae8
|
oblador#1265,Android Platform, Fonts not being copied if using Android gradle plugin 4.1.0 => FIXED
Currently, the creation and addition of tasks to the Task Graph are dependent upon the project to be evaluated while Gradle is building i.e Solution: |
- react-native JS bundle doesn't copy per-release target - react-native JS bundle adds the copy task as dependent very carefully now! - I added some metadata for the task, a "group" and "description" - Fixed formatting, 4-space indents was predominant, I went with that everywhere this is based heavily off the react-native JS bundle copy task this was developed in collaboration with @gulshan183 Fixes oblador#1265
- react-native JS bundle doesn't copy per-release target - react-native JS bundle adds the copy task as dependent very carefully now! - I added some metadata for the task, a "group" and "description" - Fixed formatting, 4-space indents was predominant, I went with that everywhere this is based heavily off the react-native JS bundle copy task this was developed in collaboration with @gulshan183 Fixes oblador#1265
) - react-native JS bundle doesn't copy per-release target - react-native JS bundle adds the copy task as dependent very carefully now! - I added some metadata for the task, a "group" and "description" - Fixed formatting, 4-space indents was predominant, I went with that everywhere this is based heavily off the react-native JS bundle copy task this was developed in collaboration with @gulshan183 Fixes #1265
Environment
Android, android-gradle-plugin 4.1.0 (works fine with 4.0.2)
Description
Try to do a build with selective font inclusion:
./android/app/build.gradle
Reproducible Demo
Let us know how to reproduce the issue. Include a code sample, share a project, or share an app that reproduces the issue using https://snack.expo.io/. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve
I think this is similar to facebook/react-native#30177
The text was updated successfully, but these errors were encountered: