Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed fetching stories on Storybook 8 with storybook-static #535

Open
PFight opened this issue Feb 19, 2025 · 1 comment
Open

Failed fetching stories on Storybook 8 with storybook-static #535

PFight opened this issue Feb 19, 2025 · 1 comment

Comments

@PFight
Copy link

PFight commented Feb 19, 2025

Latest Loki 0.35.1 don't work with latest Storybook 8.5.7 in CI mode (--reactUri file:./storybook-static)

Repro

https://github.com/PFight/loki-storybook8-fail

Steps to reproduce

  1. Switch to branch "latest"
  2. npm install --force
  3. npm run build-storybook
  4. npm run loki

Error

$ npm run loki

> [email protected] loki
> loki --diffingEngine looks-same --chromeTolerance 3 --chromeRetries 5 --chromeConcurrency 2  --reactUri file:./storybook-static  --chromeFlags="--disable-web-security --hide-scrollbars --headless"

loki test v0.35.0
(node:25052) NOTE: The AWS SDK for JavaScript (v2) is in maintenance mode.
 SDK releases are limited to address critical bug fixes and security issues only.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the blog post at https://a.co/cUPnyil
(Use `node --trace-warnings ...` to show where the warning was created)
 FAIL  chrome.app
       Fetching stories
       Failed fetching stories because the server is down
       Try starting it with "yarn storybook" or pass the --port or --host
       arguments if it's not running at http://192.168.251.14:10214
Some visual tests failed to run

Additional info

Loki works with running storybook (not static). Problem only with static-storybook.

Loki 0.31.1 works with Storybook 7.6.17
Loki 0.31.1 does not works with Storybook 8.5.7
Loki 0.35.1 does not works with Storybook 7.6.17
Loki 0.35.1 does not works with Storybook 8.5.7

Tested with Node v22.14.0.

(in different versions combination error changes)

Looks like #503 does not fixed for storybook-static.

@MarceloBarrera
Copy link

@PFight if you serve your static-storybook with http-server for example like this: pnpm http-server ./storybook-static --port 6006 is it being served? and then when you try to run for example pnpm loki test does it work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants