-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude yanked releases when choosing baseline version #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm excited to have test coverage on this tricky logic! Thanks for putting it together.
It would be good to add two more test cases that check & document that when all versions are either yanked or pre-releases, cargo-semver-checks will pick the largest-numbered version regardless of whether it's been yanked or is a pre-release. (One test where it's yanked and one where it's a pre-release.)
Added! They revealed that my logic of handling yanked versions was not behaving as it should (it was ignoring yanked releases when there weren't any normal one). I fixed this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! @tonowak if your concerns are also resolved, let's merge?
Closes #254
Extracts the selection of baseline version to a separate function, adds tests for it.