Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch breakage related to macro re-exports #968

Open
2 tasks
obi1kenobi opened this issue Oct 15, 2024 · 0 comments
Open
2 tasks

Catch breakage related to macro re-exports #968

obi1kenobi opened this issue Oct 15, 2024 · 0 comments
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

#946 states that macros are always at top level. This is nearly always true in practice, but doesn't always have to be the case as conversation in #966 shows.

Action items, in order:

  • update our data model and import tracking in trustfall-rustdoc-adapter to handle macro exports and their re-exports
  • update lints in New lints: Breaking changes in macros #946 to include importable_path clauses, so that we catch breakage on all re-exports of macros, not just the top-level exports
@obi1kenobi obi1kenobi added A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

1 participant