Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --workspace flag enabled by default in workspaces? #161

Closed
obi1kenobi opened this issue Oct 27, 2022 · 2 comments
Closed

Make --workspace flag enabled by default in workspaces? #161

obi1kenobi opened this issue Oct 27, 2022 · 2 comments
Assignees

Comments

@obi1kenobi
Copy link
Owner

Should the --workspace flag be enabled by default when running in a workspace?

Right now, running cargo semver-checks check-release in a workspace will only check the top-level crate in the workspace, if there is one. It might not be obvious to users that this is the case, and it's plausible that users might not know that they need to add a flag like --workspace to check other crates as well.

@epage
Copy link
Collaborator

epage commented Oct 28, 2022

This is the same behavior as native cargo commands that operate on packages when run in a workspace. Commands like cargo update and cargo clean operate exclusively on the workspace level and don't take a flag.

Before we can answer this, we need to answer #86.

@obi1kenobi
Copy link
Owner Author

Let's stick to matching cargo's behavior on this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants