Improve wait-for-redis logic #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pieter van der Giessen <[email protected]>
Contributor
pierluigilenoci
left a comment
pierluigilenoci
left a comment
There was a problem hiding this comment.
Can you please also edit the Chart.yaml file bumping the chart version and editing the artifacthub.io/changes section?
Contributor
|
To test the cases covered by #191 you can try using |
Signed-off-by: Pieter van der Giessen <[email protected]>
Contributor
Author
|
Done |
pierluigilenoci
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #182
Tested the standalone mode OK (both with Deployments and Statefulsets, which was my original use case)
Cannot test sentinel and cluster, because I also run into #191