Campaign Alias handling bug

[cobsec]

Hey all - seems to be a bug with converting campaign entities that have aliases / names from 1 to 2. TypeError raised:

You can see that an object is trying to be string'd rather than the value so can't get json serialised. I had a play and think I found the problem:

def convert_campaign(camp, bundle_instance, parent_created_by_ref, parent_timestamp):
    campaign_instance = create_basic_object("campaign", camp, parent_timestamp)
    process_description_and_short_description(campaign_instance, camp)
    campaign_instance["name"] = camp.title
    if camp.names is not None:
        campaign_instance["aliases"] = []
        for name in camp.names:
            campaign_instance["aliases"].append(name)
    # process information source before any relationships

append(name) should read append(name.value) I think?

Making the change seems to work for my test case:

[gtback]

Thanks for opening this, @cobsec and sorry for not seeing it right away. I'll hopefully have a chance to look at it soon.