Mina-signer: make secret field of KeyPair public #2755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimkiv
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2755 +/- ##
==========================================
- Coverage 71.91% 71.88% -0.03%
==========================================
Files 257 257
Lines 60412 60378 -34
==========================================
- Hits 43443 43402 -41
- Misses 16969 16976 +7 ☔ View full report in Codecov by Sentry. |
|
Can this be merged ? |
Member
Author
Let me check the CI. |
dannywillems
force-pushed
the
dw/make-secret-field-public-mina-signer
branch
from
02d9eeb to
9b2ad57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used by the upstream OpenMina. See https://github.com/o1-labs/proof-systems/pull/2750/files.