-
Notifications
You must be signed in to change notification settings - Fork 136
CI refactoring, test coverage data gathering and reports generation. #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No, we should not. It is fine for now, IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Feel free to continue with the tasks left.
I tested a few make targets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2504 +/- ##
==========================================
+ Coverage 73.17% 73.18% +0.01%
==========================================
Files 233 233
Lines 53846 53885 +39
==========================================
+ Hits 39401 39437 +36
- Misses 14445 14448 +3 ☔ View full report in Codecov by Sentry. |
… with coverage as part of regular checks, remove flag from coverage uploading to see if it helps with diff processing.
dannywillems
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already approving as it seems it is only related to the linter now.
Released earlier this year in July. No big changes. Only bumping up to stay up-to-date.
CI: bump up setup-ocaml version to v3
… and make Nightly builds on demand with the coverage report attached to the job execution results rather than upload it to the Codecov to not mess the diff checks.
…heavy, everything else will be executed during the Nightly runs.
|
Hey folks, |
Agree. |
|
@shimkiv is it possible to get this into |
|
@volhovm everything is possible, I'm just thinking which changes you'd like to have in |
|
^ (discussed yesterday in PM, but copying): I'd ideally like to see the CI files/Makefile structure synchronized between this repo's |
Makefile.makecommand on Windows natively (not sure though if we have users who build stuff on Windows without the WSL).Maketargets?.mdfiles.Tasks left:
matrix).make nextest-with-coveragefor one of therust_toolchain_version: ["1.71", "1.72", "1.73", "1.74"].make nextest-heavy-with-coverageinto Nightly builds with on-demand execution option.CONTRIBUTING.md.CARGO_EXTRA_ARGS="-p poly-commitment" make test-all-with-coverageBIN_EXTRA_ARGS="-p poly-commitment" make nextest-all-with-coverage