Added log if initial peers are invalid #1703

0xMimir · 2025-12-03T08:32:53Z

github-actions · 2025-12-03T08:33:16Z

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output

Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: ca1a7cf11f6b5c6d184bedbabb98957098f2791b

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: ca1a7cf11f6b5c6d184bedbabb98957098f2791b)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

github-actions · 2025-12-03T08:33:57Z

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

dannywillems · 2025-12-04T16:39:29Z

Looking at it now.
Running:

cargo run \
  -r \
  --bin mina -- \
    node \
    -P /ip4/5.5.5.5/tcp/8302/p2p/12D3KooWAMKZM7ysxRka2RfQWxCXXFTopjZ1eZcwtSi4VPgcdont

dannywillems · 2025-12-04T16:45:14Z

node/src/reducer.rs

+            crate::core::error!(
+                crate::core::log::system_time();
+                summary = "Exiting",
+                error = "Invalid initial peers"


We are continuously printing on the stdout:

2025-12-04T16:42:16.552063Z ERROR node::reducer: time="1764866536552054251" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:16.656957Z ERROR node::reducer: time="1764866536656948167" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:16.761831Z ERROR node::reducer: time="1764866536761823042" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:16.866726Z ERROR node::reducer: time="1764866536866719208" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:16.971191Z ERROR node::reducer: time="1764866536971179084" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.076161Z ERROR node::reducer: time="1764866537076153209" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.181250Z ERROR node::reducer: time="1764866537181236750" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.286159Z ERROR node::reducer: time="1764866537286148292" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.391037Z ERROR node::reducer: time="1764866537391026792" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.496219Z ERROR node::reducer: time="1764866537496203709" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.601182Z ERROR node::reducer: time="1764866537601171959" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.706175Z ERROR node::reducer: time="1764866537706161792" summary="Exiting" error="Invalid initial peers" 2025-12-04T16:42:17.811069Z ERROR node::reducer: time="1764866537811057709" summary="Exiting" error="Invalid initial peers"

However, it does not say which peers to remove. I know from the command I run for my test, but a user might be confused. Can you make it more explicit, please?

dannywillems · 2025-12-04T16:46:55Z

node/src/action.rs

    RpcEffectful(RpcEffectfulAction),

    WatchedAccounts(WatchedAccountsAction),
+    Exit(ExitAction),


There is no documentation for the others. Could you add a one-liner please?

Also, why do you call it Exit? By reading the code, I would have expected that it is an action to kill the node. But it is simply writing an error message. It is inconsistent with what we would expect by reading the code.

dannywillems · 2025-12-04T16:47:37Z

node/src/reducer.rs

+                    if p2p.ready_peers().is_empty() && kad_state.has_bootstraped {
+                        if let Some(tip) = &state.transition_frontier.best_tip_breadcrumb() {
+                            // TODO: this might need to change in future
+                            if tip.height() == 296372 {


Where does this value come from?

dannywillems · 2025-12-04T16:48:57Z

CHANGELOG.md

  Dashboard, documenting all endpoints and specific data fields used by the
  frontend ([#1566](https://github.com/o1-labs/mina-rust/issues/1566))

+- **FEATURE**: Add logging if initial peers are invalid


Suggested change

- **FEATURE**: Add logging if initial peers are invalid

- **Feature**: Add logging if an initial peer is invalid

FEATURE -> Feature: there is no need to capitalize the word.
Plural -> singular: one initial peer is enough to have a log.

dannywillems · 2025-12-04T16:50:26Z

p2p/src/network/kad/p2p_network_kad_state.rs

    pub streams: StreamState<P2pNetworkKadStreamState>,
    pub status: P2pNetworkKadStatus,
    pub filter_addrs: bool,
+    pub has_bootstraped: bool,


Is it still related to the initial goal of this patch? I don't understand the link.

I see, it is used in a condition above.

dannywillems

See comments

github-project-automation bot added this to Rust node Dec 3, 2025

0xMimir force-pushed the feat/add-exit branch 2 times, most recently from 9033737 to b7212dd Compare December 3, 2025 10:04

0xMimir changed the title ~~Added exit if initial peers are invalid~~ Added log if initial peers are invalid Dec 3, 2025

0xMimir force-pushed the feat/add-exit branch 3 times, most recently from 35f70b1 to adf6fba Compare December 3, 2025 10:44

0xMimir requested a review from dannywillems December 3, 2025 12:40

0xMimir force-pushed the feat/add-exit branch from adf6fba to e8a0d18 Compare December 3, 2025 15:11

dannywillems force-pushed the feat/add-exit branch from e8a0d18 to 6f9b84b Compare December 3, 2025 23:12

0xMimir force-pushed the feat/add-exit branch 2 times, most recently from 51216b4 to 38dc53f Compare December 4, 2025 08:06

dannywillems assigned 0xMimir Dec 4, 2025

dannywillems moved this to In Review in Rust node Dec 4, 2025

Added log if initial peers are invalid

c25cfb5

dannywillems force-pushed the feat/add-exit branch from 38dc53f to c25cfb5 Compare December 4, 2025 16:21

dannywillems linked an issue Dec 4, 2025 that may be closed by this pull request

Node runs indefinitely and doesn't exit if initial peer is invalid/offline #1641

Open

dannywillems reviewed Dec 4, 2025

View reviewed changes

dannywillems moved this from In Review to In Progress in Rust node Dec 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added log if initial peers are invalid #1703

Added log if initial peers are invalid #1703

0xMimir commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

dannywillems commented Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Uh oh!

dannywillems left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	- FEATURE: Add logging if initial peers are invalid
	- Feature: Add logging if an initial peer is invalid

Added log if initial peers are invalid #1703

Are you sure you want to change the base?

Added log if initial peers are invalid #1703

Conversation

0xMimir commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OCaml Reference Validation Results

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✓ Code Reference Verification Passed

Uh oh!

dannywillems commented Dec 4, 2025

Uh oh!

dannywillems Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 3, 2025 •

edited

Loading

github-actions bot commented Dec 3, 2025 •

edited

Loading