Merge pull request #766 from openmina/ci/webrtc_tests/enable

Ci: enable webrtc tests

Author: binier

.github/workflows/ci.yaml

@@ -167,7 +167,6 @@ jobs:
 
   build-tests-webrtc:
     runs-on: ubuntu-20.04
-    if: false
     steps:
       - name: Git checkout
         uses: actions/checkout@v4
@@ -199,11 +198,11 @@ jobs:
       - name: Upload tests
         uses: actions/upload-artifact@v4
         with:
-          name: tests-webrct
+          name: tests-webrtc
           path: target/release/tests
 
   p2p-scenario-tests:
-    needs: [ build-tests ]
+    needs: [ build-tests, build-tests-webrtc ]
     runs-on: ubuntu-20.04
     container:
       image: minaprotocol/mina-daemon:3.0.0-dc6bf78-focal-devnet
@@ -212,7 +211,8 @@ jobs:
       BPF_ALIAS: /coda/0.0.1/29936104443aaf264a7f0192ac64b1c7173198c1ed404c1bcff5e562e05eb7f6-0.0.0.0
     strategy:
       matrix:
-        test: [p2p_basic_connections, p2p_basic_incoming, p2p_basic_outgoing, p2p_pubsub, p2p_kad]
+        test: [p2p_basic_connections, p2p_basic_incoming, p2p_basic_outgoing, p2p_pubsub, p2p_kad,
+               webrtc_p2p_basic_connections]
       fail-fast: false
 
     services:
@@ -231,7 +231,8 @@ jobs:
       - name: Download tests
         uses: actions/download-artifact@v4
         with:
-          name: tests
+          pattern: tests*
+          merge-multiple: true
 
       - name: Setup permissions
         run: |
@@ -355,7 +356,7 @@ jobs:
     needs:
       - k8s-peers
       - build-tests
-    #  - build-tests-webrtc
+      - build-tests-webrtc
     runs-on: ubuntu-20.04
     container:
       image: minaprotocol/mina-daemon:3.0.0-dc6bf78-focal-devnet
@@ -365,7 +366,7 @@ jobs:
       OPENMINA_SCENARIO_SEEDS: ${{ needs.k8s-peers.outputs.peers }}
     strategy:
       matrix:
-        test: [record_replay]
+        test: [record_replay, webrtc_record_replay]
       fail-fast: false
 
     steps:

node/testing/tests/common.rs

@@ -10,8 +10,10 @@ macro_rules! scenario_doc {
 
 #[macro_export]
 macro_rules! scenario_test {
-
     ($(#[$meta:meta])? $name:ident, $scenario:ty, $scenario_instance:expr) => {
+        scenario_test!($(#[$meta])? $name, $scenario, $scenario_instance, false);
+    };
+    ($(#[$meta:meta])? $name:ident, $scenario:ty, $scenario_instance:expr, $can_test_webrtc:expr) => {
         #[tokio::test]
         $(#[$meta])?
         async fn $name() {
@@ -55,7 +57,13 @@ macro_rules! scenario_test {
                 }));
             }
 
-            let config = ClusterConfig::new(None).unwrap();
+            #[allow(unused_mut)]
+            let mut config = ClusterConfig::new(None).unwrap();
+            #[cfg(feature = "p2p-webrtc")]
+            if $can_test_webrtc {
+                eprintln!("All rust to rust connections will be over webrtc transport");
+                config = config.set_all_rust_to_rust_use_webrtc();
+            }
             let mut cluster = Cluster::new(config);
             let runner = ClusterRunner::new(&mut cluster, |_| {});
             let scenario = $scenario_instance;

node/testing/tests/p2p_basic_incoming.rs

@@ -7,10 +7,12 @@ mod common;
 scenario_test!(
     accept_connection,
     AcceptIncomingConnection,
-    AcceptIncomingConnection
+    AcceptIncomingConnection,
+    true
 );
 scenario_test!(
     accept_multiple_connections,
     AcceptMultipleIncomingConnections,
-    AcceptMultipleIncomingConnections
+    AcceptMultipleIncomingConnections,
+    true
 );

node/testing/tests/p2p_basic_outgoing.rs

@@ -9,23 +9,27 @@ mod common;
 scenario_test!(
     make_connection,
     MakeOutgoingConnection,
-    MakeOutgoingConnection
+    MakeOutgoingConnection,
+    true
 );
 scenario_test!(
     make_multiple_connections,
     MakeMultipleOutgoingConnections,
-    MakeMultipleOutgoingConnections
+    MakeMultipleOutgoingConnections,
+    true
 );
 
 scenario_test!(
     dont_connect_to_node_same_id,
     DontConnectToNodeWithSameId,
-    DontConnectToNodeWithSameId
+    DontConnectToNodeWithSameId,
+    true
 );
 scenario_test!(
     dont_connect_to_initial_peer_same_id,
     DontConnectToInitialPeerWithSameId,
-    DontConnectToInitialPeerWithSameId
+    DontConnectToInitialPeerWithSameId,
+    true
 );
 scenario_test!(
     dont_connect_to_self_initial_peer,
@@ -36,15 +40,18 @@ scenario_test!(
 scenario_test!(
     connect_to_all_initial_peers,
     ConnectToInitialPeers,
-    ConnectToInitialPeers
+    ConnectToInitialPeers,
+    true
 );
 scenario_test!(
     connect_to_offline_initial_peers,
     ConnectToUnavailableInitialPeers,
-    ConnectToUnavailableInitialPeers
+    ConnectToUnavailableInitialPeers,
+    true
 );
 scenario_test!(
     connect_to_all_initial_peers_become_ready,
     ConnectToInitialPeersBecomeReady,
-    ConnectToInitialPeersBecomeReady
+    ConnectToInitialPeersBecomeReady,
+    true
 );

node/testing/tests/record_replay.rs

@@ -7,11 +7,13 @@ mod common;
 scenario_test!(
     record_replay_bootstrap,
     RecordReplayBootstrap,
-    RecordReplayBootstrap
+    RecordReplayBootstrap,
+    true
 );
 
 scenario_test!(
     record_replay_block_production,
     RecordReplayBlockProduction,
-    RecordReplayBlockProduction
+    RecordReplayBlockProduction,
+    true
 );