Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tall images cut off when expanded #297

Closed
afischer opened this issue Oct 8, 2021 · 1 comment · Fixed by #299
Closed

Tall images cut off when expanded #297

afischer opened this issue Oct 8, 2021 · 1 comment · Fixed by #299
Assignees
Labels
bug Something isn't working

Comments

@afischer
Copy link
Member

afischer commented Oct 8, 2021

Context (Environment)

Very tall, high resolution images can be cut off as they expand to fill the width of the window. You can not scroll down as that triggers the modal to close.

image

Expected Behavior

The entire image should be visible/accessible in the expanded state.

Actual Behavior

The image is cut off, and scrolling closes the image modal.

Possible Solution

Either change the CSS to make the image fill the screen, or allow scrolling through the image if it is too tall.

@afischer afischer added the bug Something isn't working label Oct 8, 2021
@xvandish
Copy link
Contributor

xvandish commented Oct 21, 2021

@afischer I'll take this up if thats ok? I can also handle the other image related bugs if they're still open!

@xvandish xvandish mentioned this issue Oct 21, 2021
5 tasks
@afischer afischer linked a pull request Oct 28, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants