Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click to zoom on photos/modal images #268

Closed
afischer opened this issue Jun 4, 2021 · 3 comments · Fixed by #283
Closed

Click to zoom on photos/modal images #268

afischer opened this issue Jun 4, 2021 · 3 comments · Fixed by #283
Assignees
@xvandish
Labels
enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses in progress A member of the community is currently working on a fix

Comments

@afischer
Copy link
Member

afischer commented Jun 4, 2021

Problem Description

Some photos can be difficult to see at the size library presents them. It would be great to add a way to zoom or pop open photos to a larger size on click.

Feature

  • Images should show the zoom cursor on image hover
  • Clicking an image causes it to zoom, filling to the window's width or to 100% size of the image, whatever is smallest
@afischer afischer added enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses labels Jun 4, 2021
@xvandish
Copy link
Contributor

@afischer cool if I take up this work?

@afischer
Copy link
Member Author

Sure! Assigned — Let me know if there's anything I can do to help.

@xvandish
Copy link
Contributor

cool! sure, I'll reach out if anything

@xvandish xvandish mentioned this issue Aug 5, 2021
Merged
5 tasks
@afischer afischer linked a pull request Aug 10, 2021 that will close this issue
Feature/img modal #283
Merged
5 tasks
@afischer afischer added the in progress A member of the community is currently working on a fix label Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xvandish xvandish

Labels
enhancement New feature or request good first issue Good for newcomers to the project that are familiar with the tech Library uses in progress A member of the community is currently working on a fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/img modal nytimes/library
2 participants
@afischer @xvandish