We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observed this in the logs on our own copy of Library, which should not be causing a 500.
'Unknown language: "archieml"'
This is probably coming from the new syntax highlighting code added in the most recent release.
When the language is unknown, we should render without syntax highlighting.
The app returns a 500 until the unknown language is removed
Try creating a code snippet where the language is archieml
archieml
Use a try/catch in this section of the formatter code, so that errors thrown by hljs are nonfatal: https://github.com/nytimes/library/blob/master/server/formatter.js#L112-L116
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Context (Environment)
Observed this in the logs on our own copy of Library, which should not be causing a 500.
This is probably coming from the new syntax highlighting code added in the most recent release.
Expected Behavior
When the language is unknown, we should render without syntax highlighting.
Actual Behavior
The app returns a 500 until the unknown language is removed
To Reproduce
Try creating a code snippet where the language is
archieml
Possible Solution
Use a try/catch in this section of the formatter code, so that errors thrown by hljs are nonfatal: https://github.com/nytimes/library/blob/master/server/formatter.js#L112-L116
The text was updated successfully, but these errors were encountered: