Skip to content

Commit e8f66a7

Browse files
committed
streams: add stream.pipe
pipe is similar to pipeline however it supports stream composition. Refs: nodejs#32020
1 parent 4e17ffc commit e8f66a7

File tree

2 files changed

+109
-0
lines changed

2 files changed

+109
-0
lines changed

lib/internal/streams/pipelinify.js

+107
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
'use strict';
2+
3+
const pipeline = require('internal/streams/pipeline');
4+
const Duplex = require('internal/streams/duplex');
5+
const { destroyer } = require('internal/streams/destroy');
6+
7+
module.exports = function pipe(...streams) {
8+
let ondrain;
9+
let onfinish;
10+
let onreadable;
11+
let onclose;
12+
let ret;
13+
14+
const r = pipeline(streams, function(err) {
15+
if (onclose) {
16+
const cb = onclose;
17+
onclose = null;
18+
cb(err);
19+
} else {
20+
ret.destroy(err);
21+
}
22+
});
23+
const w = streams[0];
24+
25+
const writable = w.writable;
26+
const readable = r.readable;
27+
const objectMode = w.readableObjectMode;
28+
29+
ret = new Duplex({
30+
writable,
31+
readable,
32+
objectMode,
33+
highWaterMark: 1
34+
});
35+
36+
if (writable) {
37+
ret._write = function(chunk, encoding, callback) {
38+
if (w.write(chunk, encoding)) {
39+
callback();
40+
} else {
41+
ondrain = callback;
42+
}
43+
};
44+
45+
ret._final = function(callback) {
46+
w.end();
47+
onfinish = callback;
48+
};
49+
50+
ret.on('drain', function() {
51+
if (ondrain) {
52+
const cb = ondrain;
53+
ondrain = null;
54+
cb();
55+
}
56+
});
57+
58+
ret.on('finish', function() {
59+
if (onfinish) {
60+
const cb = onfinish;
61+
onfinish = null;
62+
cb();
63+
}
64+
});
65+
66+
const write = Duplex.prototype.write;
67+
// Writable.write unfortunately checks buffering before
68+
// writing, and not after due to https://github.com/nodejs/node/pull/35941.
69+
// We need to override this in order to avoid buffering overhead.
70+
ret.write = function (chunk, encoding, cb) {
71+
return write.call(ret, chunk, encoding, cb) && !ondrain;
72+
}
73+
}
74+
75+
if (readable) {
76+
r.on('readable', function() {
77+
if (onreadable) {
78+
const cb = onreadable;
79+
onreadable = null;
80+
cb();
81+
}
82+
});
83+
84+
ret._read = function() {
85+
while (true) {
86+
const buf = r.read();
87+
88+
if (buf === null) {
89+
onreadable = ret._read;
90+
return;
91+
}
92+
93+
if (!ret.push(buf)) {
94+
return;
95+
}
96+
}
97+
};
98+
}
99+
100+
ret._destroy = function(err, callback) {
101+
onclose = callback;
102+
onreadable = null;
103+
ondrain = null;
104+
onfinish = null;
105+
destroyer(r, err);
106+
};
107+
};

lib/stream.js

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const {
3030
} = require('internal/util');
3131

3232
const pipeline = require('internal/streams/pipeline');
33+
const pipelinify = require('internal/streams/pipelinify');
3334
const eos = require('internal/streams/end-of-stream');
3435
const internalBuffer = require('internal/buffer');
3536

@@ -42,6 +43,7 @@ Stream.Duplex = require('internal/streams/duplex');
4243
Stream.Transform = require('internal/streams/transform');
4344
Stream.PassThrough = require('internal/streams/passthrough');
4445
Stream.pipeline = pipeline;
46+
Stream.pipelinify = pipelinify;
4547
const { addAbortSignal } = require('internal/streams/add-abort-signal');
4648
Stream.addAbortSignal = addAbortSignal;
4749
Stream.finished = eos;

0 commit comments

Comments
 (0)