From 785bc53b6afcf46546ccc68d6675c49384538e91 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 24 Jul 2021 06:37:56 -0700 Subject: [PATCH] build: use Node.js 14 in commit-lint.yml All of our workflows use Node.js 14.x or 16.x except for commit-lint.yml which has 12.x hard-coded. Update it to 14.x and change it to using an environment variable so it is consistent with our other workflows. PR-URL: https://github.com/nodejs/node/pull/39506 Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- .github/workflows/commit-lint.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/commit-lint.yml b/.github/workflows/commit-lint.yml index 66587c7cb0af24..844a2a08ef6420 100644 --- a/.github/workflows/commit-lint.yml +++ b/.github/workflows/commit-lint.yml @@ -2,6 +2,9 @@ name: "Commit messages adheres to guidelines at https://goo.gl/p2fr5Q" on: [pull_request] +env: + NODE_VERSION: 14.x + jobs: lint-commit-message: runs-on: ubuntu-latest @@ -10,10 +13,10 @@ jobs: with: # Last 100 commits should be enough for a PR fetch-depth: 100 - - name: Use Node.js 12 + - name: Install Node.js uses: actions/setup-node@v2 with: - node-version: 12.x + node-version: ${{ env.NODE_VERSION }} - name: Validate commit messages run: | echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"