Ansible Linting Errors

[etienne-miralytik]

Hey

- name: nvm
  shell: >
    curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
  args:
    creates: "{{ ansible_env.HOME }}/.nvm/nvm.sh"

this provided Ansible task from README.md has multiple Linting Errors:

command-instead-of-module: curl used in place of get_url or uri module
[...] Task/Handler: nvm

fqcn-builtins: Use FQCN for builtin actions.
[...] Task/Handler: nvm

name: All names should start with an uppercase letter. (name[casing])
[...] Task/Handler: nvm

risky-shell-pipe: Shells that use pipes should set the pipefail option.
[...] Task/Handler: nvm

The ansible-lint version used was 6.5.0

[ljharb]

Thanks!

• curl is used intentionally, because that's what the official install script uses.
• I have no idea what FQCN is, can you elaborate?
• sure, i guess? seems unimportant tho
• this script does not need the pipefail option.

[etienne-miralytik]

FQCN just means that you should use the full module name: ansible.builtin.shell

[ljharb]

A PR to make the relevant fixes would be appreciated.

[etienne-miralytik]

Well this only leaves the two minor errors, I opened PR #2861 to fix them.