Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Parallel sync and update #413

Open
mrcjkb opened this issue Jun 25, 2024 · 3 comments
Open

[Perf] Parallel sync and update #413

mrcjkb opened this issue Jun 25, 2024 · 3 comments

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Jun 25, 2024

I think I have an idea for this:

Option 1

  • First, install (shared?) dependencies sequentially
  • Then update rocks in parallel

Option 2

Implement a per-package locking mechanism in luarocks

@vhyrro
Copy link
Collaborator

vhyrro commented Jun 26, 2024

I'm inclined to start with option 1 and refactor in case option 2 ever becomes a reality. We could pester hisham a bit to try and make that work :p (hell, maybe I can try to contribute, seems like a simplish thing to implement).

The processing time of checking shared dependencies is outweighed by the speed gains of parallel updates.

@mrcjkb
Copy link
Member Author

mrcjkb commented Jul 8, 2024

Played around with this a bit more on the parallel-installs branch.
The luarocks --force-lock option is completely broken when doing parallel installs.

luarocks needs either a way to lock installs per directory or an --ignore-lock option.

@mrcjkb
Copy link
Member Author

mrcjkb commented Jul 8, 2024

Added an --ignore-lock flag to my fork of luarocks. Some packages seem to update fine, but others fail with

Warning: Failed searching manifest: Failed loading manifest for https://nvim-neorocks.github.io/rocks-binaries-dev/: Error loading file: [string "/tmp/luarocks_local_cache-7694486/https___nvi..."]:2887: ']' expected near '}'

error: no results matching query were found for lua 5.1.
to check if it is available for other lua versions, use --check-lua-versions.

It looks like we may have to improve the luarocks locking mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants