-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp removed in python 3.12 #1381
Comments
Got the same issue today when trying to re-install as well. |
Any news on this ? Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "C:\Users\SSC\scoop\apps\python\current\Scripts\thefuck.exe\__main__.py", line 4, in <module>
File "C:\Users\SSC\scoop\apps\python\current\Lib\site-packages\thefuck\entrypoints\main.py", line 8, in <module>
from .. import logs # noqa: E402
^^^^^^^^^^^^^^^^^^^
File "C:\Users\SSC\scoop\apps\python\current\Lib\site-packages\thefuck\logs.py", line 8, in <module>
from .conf import settings
File "C:\Users\SSC\scoop\apps\python\current\Lib\site-packages\thefuck\conf.py", line 1, in <module>
from imp import load_source
ModuleNotFoundError: No module named 'imp' I need to fix my mistakes myself. |
Okay the master apparently works. |
lets pray 🙏 |
installing from sources (following the contributing guide) results in a working installation |
It seems the solution might be as follows:
|
And here's a pull request to fix this issue: #1415 |
Well, at least the unit tests all pass with this branch, I couldn't figure out how to have the functional tests passing though 🤷 |
fixed with simply |
imp
is deprecated since python 3.4 and now removed in python 3.12. Currently thefuck cannot be run with python 3.12.I'm able to replace imp, but the tests also break and I don't have enough knowledge of the project to solve those. It would be appreciated if this could be fixed before September, so that I can update thefuck without resorting to ugly fixes for the Fedora 39 release.
The text was updated successfully, but these errors were encountered: