From df8dfd5fe11b6ca766616334e0cf7145b94176a2 Mon Sep 17 00:00:00 2001 From: Julien Cochuyt Date: Fri, 23 Apr 2021 03:46:49 +0200 Subject: [PATCH 1/2] Braille Viewer: Add a close button on the title bar for use with pointing devices Re https://github.com/nvaccess/nvda/issues/10791#issuecomment-646978487 --- source/brailleViewer/brailleViewerGui.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/brailleViewer/brailleViewerGui.py b/source/brailleViewer/brailleViewerGui.py index b781a29f0ce..33f3ead0a1a 100644 --- a/source/brailleViewer/brailleViewerGui.py +++ b/source/brailleViewer/brailleViewerGui.py @@ -1,5 +1,5 @@ # A part of NonVisual Desktop Access (NVDA) -# Copyright (C) 2014-2019 NV Access Limited +# Copyright (C) 2014-2021 NV Access Limited, Accessolutions, Julien Cochuyt # This file is covered by the GNU General Public License. # See the file COPYING for more details. import enum @@ -280,7 +280,7 @@ def __init__(self, numCells, onDestroyed): gui.mainFrame, title=self._title, pos=dialogPos, - style=wx.CAPTION | wx.STAY_ON_TOP + style=wx.CAPTION | wx.CLOSE_BOX | wx.STAY_ON_TOP ) self.Bind(wx.EVT_CLOSE, self._onClose) self.Bind(wx.EVT_WINDOW_DESTROY, self._onDestroy) From bd6ce2dbf91aea51be605d8aa4f7c8cd58045e49 Mon Sep 17 00:00:00 2001 From: buddsean Date: Thu, 29 Apr 2021 11:10:39 +1000 Subject: [PATCH 2/2] update changes.t2t --- user_docs/en/changes.t2t | 1 + 1 file changed, 1 insertion(+) diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t index 1791789766b..d41b7d875ef 100644 --- a/user_docs/en/changes.t2t +++ b/user_docs/en/changes.t2t @@ -26,6 +26,7 @@ What's New in NVDA - Support for Adobe Flash content has been removed from NVDA due to the use of Flash being actively discouraged by Adobe. (#11131) - NVDA will exit even with windows still open, the exit process now closes all NVDA windows and dialogs (#1740) - The Speech Viewer can now be closed with `alt+F4` and has a standard close button for easier interaction with users of pointing devices. (#12330) +- The Braille Viewer now has a standard close button for easier interaction with users of pointing devices. (#12328) == Bug Fixes ==