Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Improve clang-format include ordering #276

Closed
mdemoret-nv opened this issue Jul 14, 2022 · 2 comments
Closed

[FEA] Improve clang-format include ordering #276

mdemoret-nv opened this issue Jul 14, 2022 · 2 comments
Assignees
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We improved the clang-format include ordering in nv-morpheus/MRC#47 and should apply the same logic to Morpheus.

Describe the solution you'd like
Copy the clang-format include section from SRF, update it to apply to Morpheus, and then run clang format on all files to ensure a consistent include ordering.

@mdemoret-nv mdemoret-nv added the feature request New feature or request label Jul 14, 2022
@mdemoret-nv
Copy link
Contributor Author

One additional thing, in that PR we changed our include style from #include <srf/.../header.hpp> to #include "srf/.../header.hpp". We should do the same for Morpheus

@mdemoret-nv
Copy link
Contributor Author

Completed in PR #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants