-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CommandPalette): keep ignoreFilter
groups at their place
#2833
Conversation
Deploying ui3 with Β Β Cloudflare Pages
|
commit: |
@maximepvrt I remember we talked about this a few months back, do you have an opinion on this? |
@benjamincanac Yes, absolutely! It's great to see this being implemented : my original MR (#1457) π Also, your memory is incredible! |
Haha thanks, so this makes sense to you to keep original order of non fuse groups only? |
Yes, keeping the original order of non-fuse groups makes more sense to me as well it feels more logical. In my original MR, I proposed this approach mainly to avoid a breaking change in v2. If needed, we could also consider adding an option to define a placement strategy for the groups. What do you think? π |
If we do this, let's add a |
@benjamincanac Are you suggesting the order would follow the fuse logic unless manual indexes are provided? What happens to groups without indexes in cases where some do have indexes? Would they appear first, last, or follow another logic? |
Yes, they'd keep their position based on the Fuse results I guess, not sure π |
Related to #2832
π Linked issue
β Type of change
π Description
π Checklist