Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form)!: resolve async validation in yup & issue directly mutate state #2701

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Nov 20, 2024

πŸ”— Linked issue

Resolves #2691

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Breaking Change

  • Fixed schema transformation behavior: The transform method in the schema library no longer mutates the original state when submitting a form. Instead, it now returns a transformed value while keeping the original state intact. This change ensures proper state management and prevents unexpected side effects.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar requested a review from romhml November 20, 2024 01:59
Copy link

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: c06b4db
Status:🚫  Build failed.

View logs

@romhml romhml changed the title fix(Form): resolve async validation in yup & issue directly mutate state fix(Form)!: resolve async validation in yup & issue directly mutate state Nov 22, 2024
@romhml
Copy link
Collaborator

romhml commented Nov 22, 2024

Thanks @rdjanuar! For next time I think it would've been great to split the two subjects since the two fixes are not related and one of them introduces a breaking change.

@benjamincanac
Copy link
Member

Would you mind describing in the PR description the breaking change so I can put it on the next release note?

@benjamincanac benjamincanac merged commit f3632dd into dev Nov 23, 2024
2 of 3 checks passed
@benjamincanac benjamincanac deleted the issue-2691 branch November 23, 2024 18:29
@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 23, 2024

done @benjamincanac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.19.2 @nuxt/ui breaks async form validation with yup
3 participants