fix(Carousel): use dir from locale
#2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malik-Jouda
changed the title
Carousel in RTL mode
commit: |
benjamincanac
approved these changes
Nov 14, 2024
benjamincanac
changed the title
Carousel in RTL mode
|
Don't you need to rotate the arrows in horizontal mode as well? 🤔 |
Yes
|
| @@ -18,8 +18,8 @@ export default (options: Required<ModuleOptions>) => ({ | |||
| vertical: { | |||
| container: 'flex-col -mt-4', | |||
| item: 'pt-4', | |||
| prev: '-top-12 left-1/2 -translate-x-1/2 rotate-90', | |||
| next: '-bottom-12 left-1/2 -translate-x-1/2 rotate-90' | |||
| prev: '-top-12 left-1/2 -translate-x-1/2 rotate-90 rtl:-rotate-90', | |||
There was a problem hiding this comment.
But you only applied rotate for vertical mode here 🤔
There was a problem hiding this comment.
But you only applied rotate for
verticalmode here 🤔
@benjamincanac Check the image after it has been updated
benjamincanac
approved these changes
Nov 15, 2024
benjamincanac
changed the title
direction from locale
benjamincanac
changed the title
direction from localedir from locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Screen.Recording.2024-11-14.at.10.32.09.PM.mov
📝 Checklist