Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(App): remove dir prop #2630

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix(App): remove dir prop #2630

merged 4 commits into from
Nov 13, 2024

Conversation

benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Nov 13, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

After talking with @Malik-Jouda, it doesn't really make sense to override the dir prop since any app with RTL mode will have their locale set already.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member Author

@Malik-Jouda @hywax WDYT?

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2024 •
edited
Loading

Deploying ui3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5987fc9
Status: ✅  Deploy successful!
Preview URL: https://093f105b.ui-6q2.pages.dev
Branch Preview URL: https://app-dir.ui-6q2.pages.dev

View logs

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 13, 2024 •
edited
Loading 

pnpm add https://pkg.pr.new/@nuxt/ui@2630

commit: 5987fc9

@Malik-Jouda
Copy link
Contributor

@benjamincanac
Thank you for accepting this suggestion ☺️

@hywax
Copy link
Collaborator

hywax commented Nov 13, 2024

Looks good 👍

@benjamincanac benjamincanac merged commit 7cc26d0 into v3 Nov 13, 2024
3 checks passed
@benjamincanac benjamincanac deleted the app/dir branch November 13, 2024 15:23
@benjamincanac benjamincanac added the v3 #1289 label Nov 16, 2024 — with Volta.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamincanac @Malik-Jouda @hywax