-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): improve DeepPartial
type for App Config
#2621
Conversation
as const
(#2221)as const
(#2221)
I noticed that the typecheck was failing. In fact the It means that if I remove |
The source of the bug are the changes made in #1870 Fixing (or rolling back) the DeepPartial type util would be a better fix imo. |
7524b17
to
d9a17fa
Compare
as const
(#2221)
It seems there is an issue in the
|
Fixed it on |
d9a17fa
to
2fde85a
Compare
Thanks @benjamincanac ! I've just rebased it, you can merge this PR I think :) |
DeepPartial
for App Config
DeepPartial
for App ConfigDeepPartial
type for App Config
π Linked issue
Resolves #2221
β Type of change
π Description
When strict Typescript check was added, some
as const
where added too, and the resulting config type was showing the default value as the only possible value. I think this is not what was intended, so I treated all theas const
values asstring
in the config type.π Checklist