Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Badge): handle icon prop #2594

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

Malik-Jouda
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

@Malik-Jouda Should we rename this PR to "handle icon prop"?

@Malik-Jouda Malik-Jouda changed the title feat(Badge): handle icon and avatar props [v2] feat(Badge): handle icon prop Nov 11, 2024
@Malik-Jouda
Copy link
Contributor Author

Malik-Jouda commented Nov 11, 2024

@Malik-Jouda Should we rename this PR to "handle icon prop"?

@benjamincanac
Done

@benjamincanac
Copy link
Member

Why close this? πŸ€”

@Malik-Jouda Malik-Jouda restored the feat-badge branch November 12, 2024 13:37
@Malik-Jouda
Copy link
Contributor Author

Malik-Jouda commented Nov 12, 2024

Why close this? πŸ€”

@benjamincanac
I wanted to delete the branch i18n-dynamic-direction, but I accidentally deleted feat-badge. 😞

@benjamincanac benjamincanac reopened this Nov 12, 2024
@benjamincanac benjamincanac merged commit 0d1a76e into nuxt:dev Nov 12, 2024
3 checks passed
@Malik-Jouda Malik-Jouda deleted the feat-badge branch November 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants