Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): use parsed value from joi instead of original state #2587

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Nov 9, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When I try to validate a value using Joi custom method, it doesn't apply to the return value.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar requested a review from romhml November 9, 2024 18:11
@rdjanuar rdjanuar changed the title fix(Form): Use parsed value from Joi instead of state fix(Form): Use parsed value from Joi instead of original state Nov 9, 2024
Copy link

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: ea0ca19
Status:🚫  Build failed.

View logs

@benjamincanac benjamincanac changed the title fix(Form): Use parsed value from Joi instead of original state fix(Form): use parsed value from joi instead of original state Nov 11, 2024
@benjamincanac
Copy link
Member

@rdjanuar This might need to be done in v3 as well!

@benjamincanac benjamincanac merged commit acecff4 into dev Nov 11, 2024
2 of 3 checks passed
@benjamincanac benjamincanac deleted the fix/form-parse-joi branch November 11, 2024 18:29
@rdjanuar
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants