Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): missing type on props loadingState #2551

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Nov 7, 2024

πŸ”— Linked issue

Resolves #2043

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: d70b66e
Status:🚫  Build failed.

View logs

@rdjanuar rdjanuar added the bug Something isn't working label Nov 7, 2024
@rdjanuar rdjanuar changed the title fix(Table): missing type null on loading state fix(Table): missing type on props loadingState Nov 7, 2024
@benjamincanac benjamincanac merged commit 6e66990 into dev Nov 8, 2024
2 of 3 checks passed
@benjamincanac benjamincanac deleted the issue-2043 branch November 8, 2024 08:46
@benjamincanac benjamincanac removed the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:empty-state Prop Type Should Accept null in TypeScript
2 participants