Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): checkbox not checked while using props by #2401

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Oct 17, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have a problem in my company project. I want to control the comparison of my v-model via a prop called by because my initial data has a different shape than the incoming table data. For example, when using a specific field like id with a checkbox, the checkbox is not checked even though the row is selected.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar changed the title fix(Table): not checked while using props by fix(Table): checkbox not checked while using props by Oct 17, 2024
@rdjanuar
Copy link
Collaborator Author

Hi @benjamincanac,

I apologize for bothering you, but could I request an urgent review? I believe there's a major issue with the table. I have a lot of data with different shapes in the initial v-model value.

Could you please review this as soon as possible?

Thank you for your time and assistance.

@benjamincanac
Copy link
Member

LGTM! Feel free to use the @nuxt/ui-edge package to try it out if it's urgent.

@benjamincanac benjamincanac merged commit 1b7e36c into nuxt:dev Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants