Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Progress): handle carousel and carousel-inverse animations in RTL mode #2400

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix(Progress): handle carousel and carousel-inverse animations in RTL mode #2400

merged 2 commits into from
Oct 17, 2024

Conversation

Malik-Jouda
Copy link
Contributor

@Malik-Jouda Malik-Jouda commented Oct 16, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

screen-recording-2024-10-17-at-13405-am_NHtDMZ4M.mp4

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix(Progress): handle carousel and carousel-inverse animations in RTL mode. fix(Progress): handle carousel and carousel-inverse animations in RTL mode Oct 17, 2024
@benjamincanac benjamincanac merged commit 20fb46a into nuxt:dev Oct 17, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @Malik-Jouda! I might have missed lots of support for RTL in v3 if you want to have a look 😊

@Malik-Jouda
Copy link
Contributor Author

@benjamincanac
Sure! 😊

@Malik-Jouda Malik-Jouda deleted the fix/progress-in-rtl branch October 18, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Malik-Jouda @benjamincanac @MalikJouda