-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAlert description slot in div #1551
UAlert description slot in div #1551
Comments
I'm not fully sure to follow you here: would you like explicitly note in the docs that the |
I'm suggesting that it be a |
I've opened a PR to add a default slot to the This makes us not break the current functionality but adds the ability to insert custom components or code. |
I agree that having divs for descriptions would allow more possibilities but wouldn't that worsen SEO? |
@benjamincanac cant we just do a dynamic component with default as p tag and document it? Think this would be good as it is what people are most used to adding default tract in slot instead of as prop. Thoughts |
Here is how I fixed in in |
Description
Trying to place a
div
in a UAlert leads to hydration mismatches because both the#title
and#description
arep
tags.It's not clear to me that the
#description
should be in ap
tag; and it'd be nice to put more substantial content inside an alert.Additional context
Related issue
The text was updated successfully, but these errors were encountered: