Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vitest-environment): respect custom url in setup #957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(vitest-environment): respect custom url in setup #957

wants to merge 1 commit into from

Conversation

harunari0928
Copy link

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Removed the hardcoded window URL. Now it references an environment option for better configurability.

@harunari0928 harunari0928 marked this pull request as ready for review September 28, 2024 02:37
danielroe
danielroe reviewed Sep 28, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

@danielroe danielroe changed the title fix: eliminate hardcoded window URL ix(vitest-environment): respect custom url in setup Sep 28, 2024
@danielroe danielroe changed the title ix(vitest-environment): respect custom url in setup fix(vitest-environment): respect custom url in setup Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harunari0928 @danielroe