load mjs files as javascript/auto

[aldarund]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #3892

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests passed.

[pi0]

I think mjs spec strictly forbids use of require. Maybe we can offer users to extend webpack config instead of changing it to something non standard. Or Simply they can use js if require is needed.

[pi0]

Another note: We don't know what optimization and behavior would webpack have for mjs type in the future. If we behave .mjs as js/auto (Same as js) then what's the point of setting mja extension instead of js?

[aldarund]

@pi0 there no require in the mjs file itself. But it endsup in generated code.

 function(e, t, n) {
    "use strict";
    (function(e) {
        t.a = function(e, t) {
            return e instanceof t
        }
    }
    ).call(this, require("./../../process/browser.js"))
}

And its ends up in browser error on page load, not a compile time error

Fix was stolen from here : aws-amplify/amplify-js#686 (comment)

[clarkdo]

@pi0 is correct, webpack now is using javascript/esm for .mjs file, it's more strictly, dynamic modules (non-esm, i. e. CommonJs) can only imported via default import, everything else (including namespace import) emit error

If we use javascript/auto, .mjs functionality will be limited, because it will be treated as a js and lost the .mjs features (Although it's still WIP) 😄

[aldarund]

@clarkdo @pi0 digged a bit deeper, ye, you are right. Im not sure why and how issue with nuxt/apollo happens because i dont see any require inside graphql mjs files. But updating graphql to 14 fixes the problem. Il open a pr to vue-cli-appollo-plugin with version bump then :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.