Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): Add missing loading property to Component options #4786

Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix(ts): Add missing loading property to Component options #4786

merged 1 commit into from
Jan 17, 2019

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented Jan 17, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

See :
https://nuxtjs.org/examples/custom-page-loading => about.vue
https://github.com/nuxt/nuxt.js/blob/dev/packages/vue-app/template/client.js#L388

This PR add missing typedefs and is also linked to missing documentation of the loading property in pages/components.

Todo

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: en: Add docs for loading property docs#1111)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #4786 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4786   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          67       67           
  Lines        2288     2288           
  Branches      569      569           
=======================================
  Hits         2078     2078           
  Misses        187      187           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add233c...4cc235c. Read the comment docs.

@atinux atinux merged commit db4001d into nuxt:dev Jan 17, 2019
@kevinmarrec kevinmarrec deleted the loading-component-option-typedef branch January 17, 2019 21:07
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants