fix(examples): use testURL and module names #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAlexLichter
previously approved these changes
Jan 16, 2019
Codecov Report
@@ Coverage Diff @@
## dev #4777 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 67 67
Lines 2288 2288
Branches 569 569
=======================================
Hits 2078 2078
Misses 187 187
Partials 23 23Continue to review full report at Codecov.
|
pi0
approved these changes
Jan 17, 2019
pi0
reviewed
Jan 17, 2019
| ], | ||
| "collectCoverage": true, | ||
| "collectCoverageFrom": [ | ||
| "<rootDir>/components/**/*.vue", | ||
| "<rootDir>/pages/*.vue" | ||
| ] | ||
| ], | ||
| "testURL": "http://localhost/" |
There was a problem hiding this comment.
Shouldn't we specify default listen port here? (http://localhost:3000)
There was a problem hiding this comment.
apparently not, having just the hostname is enough to remove the SecurityError: localStorage is not available for opaque origins error
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist:
I updated the jest example by removing unnecessary that I have found to create problem when having multiple version of babel. I also added the testURL property (jsdom/jsdom#2304)