Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace babel-plugin-transform-vue-jsx with @vue/babel-preset-jsx #4740

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jan 11, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolve #4738

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #4740 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4740   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          67       67           
  Lines        2282     2282           
  Branches      565      565           
=======================================
  Hits         2057     2057           
  Misses        202      202           
  Partials       23       23
Impacted Files Coverage Δ
packages/babel-preset-app/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebd6b7...7fa88b9. Read the comment docs.

@clarkdo clarkdo merged commit da8a3d8 into nuxt:dev Jan 11, 2019
@clarkdo clarkdo deleted the babel-preset-jsx branch April 2, 2019 13:04
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace babel-plugin-transform-vue-jsx with @vue/babel-preset-jsx
4 participants