-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ts): adds function type definition for ComponentOptions.middleware
#4531
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4531 +/- ##
=======================================
Coverage 91.07% 91.07%
=======================================
Files 61 61
Lines 2184 2184
Branches 528 528
=======================================
Hits 1989 1989
Misses 177 177
Partials 18 18 Continue to review full report at Codecov.
|
ComponentOptions.middleware
ComponentOptions.middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hartmut-co-uk I think that the 2 last tests can be omitted 🤔
Thx @kevinmarrec |
74ebef3
to
466290a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is perfect to me.
PR is merge-ready !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Better TS support: Adds function typings to
ComponentOptions.middleware
.Types of changes
Description
After discussion with @kevinmarrec added type defs for functions.
Checklist: