feat: check modern build file in modern mode #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4467 +/- ##
==========================================
+ Coverage 91.35% 91.36% +0.01%
==========================================
Files 60 60
Lines 2105 2108 +3
Branches 506 508 +2
==========================================
+ Hits 1923 1926 +3
Misses 167 167
Partials 15 15
Continue to review full report at Codecov.
|
pi0
reviewed
Dec 2, 2018
| throw new Error( | ||
| 'No build files found. Use either `nuxt build` or `builder.build()` or start nuxt in development mode.' | ||
| ) | ||
| } else if (this.context.options.modern && !this.context.resources.modernManifest) { |
There was a problem hiding this comment.
Shouldn't we also include this check for isReady?
There was a problem hiding this comment.
do you mean change isReady to not only return boolean
I like this idea
pi0
approved these changes
Dec 4, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist: